New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

players: switch to a directory #26

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
8 participants
@jeffkaufman
Copy link
Owner

jeffkaufman commented Jan 6, 2019

Currently, when new players are added that makes merge conflicts, and requires
a lot of re-approvals. An easy way to avoid this is to use a directory instead
of a file.

Also add everyone who has asked to be added:

We should probably merge #23 first, so we don't get stuck if we lose someone
(#19).

players: switch to a directory
Currently, when new players are added that makes merge conflicts, and requires
a lot of re-approvals.  An easy way to avoid this is to use a directory instead
of a file.

Also add everyone who has asked to be added:
 * Closes #11
 * Closes #12
 * Closes #15
 * Closes #20
 * Closes #22

We should probably merge #23 first, so we don't get stuck if we lose someone
(#19).
@dchudz

dchudz approved these changes Jan 6, 2019

This was referenced Jan 6, 2019

@pavellishin

This comment has been minimized.

Copy link
Collaborator

pavellishin commented Jan 6, 2019

Oh, neat, I didn't know you could open PRs that close other PRs. How does that work?

@TheJhyde

This comment has been minimized.

Copy link
Collaborator

TheJhyde commented Jan 6, 2019

What's preventing this from being merged right now? @jeffkaufman do you need to approve your own pull request?

This was referenced Jan 6, 2019

@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 6, 2019

This still needs approval from @sligocki and @guoruibiao

@sligocki
Copy link
Collaborator

sligocki left a comment

Good idea

@pavellishin

This comment has been minimized.

Copy link
Collaborator

pavellishin commented Jan 7, 2019

@pavellishin

This comment has been minimized.

Copy link
Collaborator

pavellishin commented Jan 7, 2019

Also, it's funny that a person who isn't yet technically a player is blocking this. I guess in the future this won't be an issue - given that people will be adding themselves, and thus will implicitly approve their PRs.

@guoruibiao

This comment has been minimized.

Copy link
Collaborator

guoruibiao commented Jan 7, 2019

approval 👍

@guoruibiao
Copy link
Collaborator

guoruibiao left a comment

i think this way can help us do it better, good job.

@tnelling tnelling merged commit 4186d64 into master Jan 7, 2019

@guoruibiao guoruibiao deleted the rework-players branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment