New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches to requiring two thirds majority #31

Merged
merged 2 commits into from Jan 9, 2019

Conversation

Projects
None yet
8 participants
@TheJhyde
Copy link
Collaborator

TheJhyde commented Jan 7, 2019

This PR is being suggested instead of #29. Pull requests are merged in 2/3rds of the players, rounded up, vote in favor of it.

Reasoning: I think getting more pull requests through, with less requirements for each one, is more interesting. So we should lower the required threshold. I think 2/3rds majority is sufficient that everyone can have a say but not so stringent that requests languish forever.

Show resolved Hide resolved validate.py Outdated
Show resolved Hide resolved validate.py Outdated
@pavellishin
Copy link
Collaborator

pavellishin left a comment

I wish I could use PR's approve/request and reference a specific line change. For now, I've got a comment above:

I object to removing the reject-as-veto functionality in this PR.
(I'm not against it in principle, but I don't like seeing it as part of this rule change.)

(If this particular change is taken out, I'll approve.)

@tnelling
Copy link
Collaborator

tnelling left a comment

I concur with @pavellishin. Let's move to 2/3 majority being sufficient to merge PRs with no rejections, then consider how we might want to handle rejections.

@tnelling tnelling referenced this pull request Jan 8, 2019

Open

Steadily decrease veto power as PR ages #35

0 of 1 task complete
@TheJhyde

This comment has been minimized.

Copy link
Collaborator

TheJhyde commented Jan 8, 2019

I've put rejection blocking back in.

@TheJhyde TheJhyde dismissed stale reviews from tnelling and pavellishin Jan 8, 2019

Rejection blocking added

@jeffkaufman
Copy link
Owner

jeffkaufman left a comment

The PR description needs updating now

@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 8, 2019

looking for approval from @pavellishin @jmitchell @dchudz @vesche @guoruibiao

@dchudz

dchudz approved these changes Jan 8, 2019

@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 8, 2019

still looking for approval from @pavellishin @jmitchell @vesche

@TheJhyde TheJhyde merged commit 3074cc4 into master Jan 9, 2019

@TheJhyde TheJhyde deleted the two-thirds-majority branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment