Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Switches to requiring two thirds majority #31
This PR is being suggested instead of #29. Pull requests are merged in 2/3rds of the players, rounded up, vote in favor of it.
Reasoning: I think getting more pull requests through, with less requirements for each one, is more interesting. So we should lower the required threshold. I think 2/3rds majority is sufficient that everyone can have a say but not so stringent that requests languish forever.
left a comment
I wish I could use PR's approve/request and reference a specific line change. For now, I've got a comment above:
(If this particular change is taken out, I'll approve.)