New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Scores #32

Merged
merged 7 commits into from Jan 9, 2019

Conversation

@TheJhyde
Copy link
Collaborator

TheJhyde commented Jan 7, 2019

Gives each player 10 points. The purpose of points has not yet been established but with them in place, the potential exists for them to be used for something. Future players will be responsible for giving themselves 10 points when they join the game.

@jeffkaufman
Copy link
Owner

jeffkaufman left a comment

We haven't yet decided whether points are good or bad, so I'm fine with @TheJhyde having 11.

jeffkaufman added a commit that referenced this pull request Jan 7, 2019

points: assign points for having PRs merged
This builds on #32, giving people points for having PRs merged.  Points still don't affect your chance of winning.

Specific changes:

* Adds a function to look up how many points everyone has.
* If there's a number in your user file, that also gives you points.  So this is compatible with #32 but doesn't depend on it.

@sligocki sligocki self-requested a review Jan 7, 2019

@tnelling
Copy link
Collaborator

tnelling left a comment

I'm gonna be that guy. I see no reason to accept this initial disparity.

@TheJhyde

This comment has been minimized.

Copy link
Collaborator

TheJhyde commented Jan 8, 2019

What if I can make it worth your while, will you approve it then?

@tnelling

This comment has been minimized.

Copy link
Collaborator

tnelling commented Jan 8, 2019

I do appreciate your audacity. I'm curious to see what other people think of this.

@sligocki
Copy link
Collaborator

sligocki left a comment

Well now I just feel like a sucker :P

@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 8, 2019

Overall, I like having points files as a way to make a PR that does (a) something person X doesn't like but (b) give person X some points in exchange so you still can get their approval.

@TheJhyde

This comment has been minimized.

Copy link
Collaborator

TheJhyde commented Jan 8, 2019

Ok, fine, nobody any extra points.

@TheJhyde TheJhyde dismissed stale reviews from sligocki and tnelling Jan 8, 2019

Nobody gets extra

@pavellishin
Copy link
Collaborator

pavellishin left a comment

For what it's worth, the points-bargaining in this PR has been the highlight of the game so far for me :)

@vesche vesche self-requested a review Jan 9, 2019

@vesche
Copy link
Collaborator

vesche left a comment

echo 10 > players/vesche

<3

@TheJhyde

This comment has been minimized.

Copy link
Collaborator

TheJhyde commented Jan 9, 2019

I've updated the PR to fix a conflict with the new README file and to give vesche points.

@vesche

vesche approved these changes Jan 9, 2019

You are already 10 points

@TheJhyde

This comment has been minimized.

Copy link
Collaborator

TheJhyde commented Jan 9, 2019

I think @tnelling needs to switch his request for changes to an approval and then this can be merged.

@TheJhyde TheJhyde added the Points label Jan 9, 2019

@jeffkaufman
Copy link
Owner

jeffkaufman left a comment

re-approving after changes

Even though we're now at 2/3, needs approval from @sligocki because of the bug in #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment