New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore days_since_last_commit #58

Merged
merged 4 commits into from Jan 14, 2019

Conversation

Projects
None yet
7 participants
@tnelling
Copy link
Collaborator

tnelling commented Jan 11, 2019

The method was deleted in #37 but its use in recording the number of approvals to skip based on time elapsed was not replaced. This isn't a showstopper because if we have no approvals to skip then we won't hit the orphaned method call, but it could still block a lot of PRs.

tnelling added some commits Jan 5, 2019

@jeffkaufman
Copy link
Owner

jeffkaufman left a comment

Good catch!

jeffkaufman added a commit that referenced this pull request Jan 12, 2019

@dchudz

dchudz approved these changes Jan 12, 2019

@vesche

vesche approved these changes Jan 14, 2019

@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 14, 2019

Can we get one more of @TheJhyde @guoruibiao @pavellishin to approve? If we don't fix this in the next ~20hr we won't be able to merge anything to master.

@pavellishin

This comment has been minimized.

Copy link
Collaborator

pavellishin commented Jan 14, 2019

I've been dyin' of the flu :/ I'll try to catch up on other PRs later.

@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 14, 2019

@pavellishin I'm sorry to hear that! I hope you get better soon!

@jeffkaufman jeffkaufman merged commit 31dd4b8 into jeffkaufman:master Jan 14, 2019

pavellishin added a commit that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment