New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add me to the player list #6

Merged
merged 4 commits into from Jan 5, 2019

Conversation

Projects
None yet
3 participants
@TheJhyde
Copy link
Collaborator

TheJhyde commented Jan 4, 2019

I wish to be added to the player list. Just added a single line to players.txt

@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 5, 2019

Can you put your GitHub username in players.txt instead of your first name? That's how the system knows who's playing.

TheJhyde added some commits Jan 5, 2019

@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 5, 2019

Once @dchudz approves we can rerun the build and then you should be able to merge

@dchudz

dchudz approved these changes Jan 5, 2019

@jmitchell jmitchell referenced this pull request Jan 5, 2019

Open

My thoughts and suggestions #17

0 of 6 tasks complete
@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 5, 2019

I'm ok with this going in, as long as you promise to submit a PR to remove yourself from players.txt if you get bored and want to stop playing.

(This is only needed until we have a fix for #19)

@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 5, 2019

This is green, so you should be able to click "merge pull request" and merge this to join. I could do it, but I want to make sure it works for you.

@TheJhyde TheJhyde merged commit eab55e0 into jeffkaufman:master Jan 5, 2019

@TheJhyde

This comment has been minimized.

Copy link
Collaborator

TheJhyde commented Jan 5, 2019

Yes, it does!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment