improve grammar options diagnostics #8

Closed
wants to merge 4 commits into
from

Projects

None yet

2 participants

@rns
rns commented Oct 2, 2012

Marpa::R2::Grammar::set now reports undef's as 'non-reference' rather than empty string and croaks on empty hashes passed as grammar options.

rns added some commits Oct 2, 2012
rns convert tabs to spaces and line ends to unix
this would mess up with next commit
1ee90e8
rns improve grammar options diagnostics
Marpa::R2::Grammar::set now reports undef's as 'non-reference' rather
than empty string and croaks on empty hashes passed as grammar options.
b80b69d
rns fix ## end comment 2f4086c
@jeffreykegler

This is on my queue. I'm forced to be rather ruthless with time at the moment, but will get to this later.

@rns
rns commented Oct 7, 2012

Well, sure, that can wait.

rns improve diagnostics on PPI checking
Under cygwin 'PPI not installed' was issued when PPI was in fact
installed but Clone and/or List::MoreUtils were not and thus failed to
load from PPI. This is fixed by appending $@ to PPI_problem.

Also, PPI checking logic was refactored into Marpa::R2::Test to avoid
duplication. This required use'ing Marpa::R2::Test before BEGIN.

All changes in curly2.t after '-use Marpa::R2::Test;' are tabs to
spaces.
4097333
@jeffreykegler jeffreykegler pushed a commit that referenced this pull request Oct 18, 2012
- Diagnostic fixes per rns's pull request #8 3b616e8
@jeffreykegler

Selectively addressed in my commit 3b616e8, pushed a few seconds ago to my dev branch. You may want to check that I caught everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment