Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

implement sifter-python into import_from_csv #3

Merged
merged 13 commits into from Apr 27, 2012

Conversation

Projects
None yet
2 participants
Contributor

mikofski commented Mar 31, 2012

  • import Sifter class
  • call py-Github with Sifter fieldnames
  • TODO remote py-githun and just use api v3 with requests
  • TODO put milestones in milestones, not labels
  • TODO add comments to comments

Mark Mikofski and others added some commits Mar 31, 2012

Mark Mikofski implement sifter-python in sifter2github
* import Sifter class
* call py-Github with Sifter fieldnames
* TODO remote py-githun and just use api v3 with requests
* TODO put milestones in milestones, not labels
* TODO add comments to comments
3d8c083
Mark Mikofski use api v3
* write milestones to milestones
a2099ab
Mark Mikofski fix bug in SifterIssues
* extract issues from Sifter class
* also extract comments and milestones
93a2ab2
Mark Mikofski fix more bugs
* sifterIssues is always same type
* use attribute to distinguish between api and csv
3aea385
Mark Mikofski use json.dumps around data for POST 941c1b8
Mark Mikofski labels is an array
* deal with milestone already listed at gh
e7a19c3
Mark Mikofski not that easy to make a dict from a list
* use a generator?
34cdb14
Mark Mikofski fix comments bug
* it's a class not json!
* already extracted each comment in loop
* use c.body
c55dddb
Mark Mikofski milestones from github are json array
* come back as list?
* can you iterate?
* use ['numnber'] & ['title']
* use [] for lists!
2b031a6
Mark Mikofski delete legacy bug
* not using new_issue.number, it's i.number
abfe3fd
@mikofski mikofski use sifter.users
* compare github and sifter fullnames
* don't copy first comment
* check if comment is None/null
* allow skip user
* prompt for user full name if None
* fix bug, missing "/" in status/comments endpoints
* don't add milestone if None
948e26c
@mikofski mikofski create label if not in github
* add created lables to list
* convert github labels and milestones to lower
7a206b6
@mikofski mikofski it works
* make all store milestones lower case
d0b2d41

@jeffroche jeffroche added a commit that referenced this pull request Apr 27, 2012

@jeffroche jeffroche Merge pull request #3 from mikofski/master
implement sifter-python into import_from_csv
8e7c32b

@jeffroche jeffroche merged commit 8e7c32b into jeffroche:master Apr 27, 2012

@jeffroche jeffroche added a commit that referenced this pull request May 1, 2012

@jeffroche jeffroche Merge pull request #3 from mikofski/master
implement sifter-python into import_from_csv
f73c8f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment