Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to GTK4+libadwaita #64

Open
TheEvilSkeleton opened this issue Sep 6, 2022 · 5 comments
Open

Port to GTK4+libadwaita #64

TheEvilSkeleton opened this issue Sep 6, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@TheEvilSkeleton
Copy link

Any plans on porting to GTK4+libadwaita?

@jeffshee
Copy link
Owner

jeffshee commented Sep 7, 2022

@TheEvilSkeleton Actually, I'm not sure. For the GUI part (the control panel that write the config file), yes it's possible. But for the window that display the video wallpaper, it has some technical difficulties.

  • GTK4 doesn't have a way to embed vlc by design. We could switch to GStreamer (by using Gtk.MediaFile), but that requires some reimplantation and I'm not too sure with the performance and stability.

@VarLad
Copy link

VarLad commented Sep 7, 2022

@jeffshee Currently it uses mpv right? I can't get the hw acceleration to work with Hidamari (installed from Flathub) + MPV :/
Any way to force the --hwdec=auto-safe params?
I found the same issue in Celluloid Flatpak but loading an mpv config file with hwdec=auto-safe solved that for me

@jeffshee
Copy link
Owner

jeffshee commented Sep 8, 2022

@VarLad No, it uses VLC. You should make a new issue since your topic is different from OP. I will move yours over there.

@VarLad
Copy link

VarLad commented Sep 8, 2022

@jeffshee I'd guess Gstreamer would be a lot lighter of an alternative to VLC?
and since this is Linux-only, I'd think Gstreamer would be a better choice.

@jeffshee
Copy link
Owner

jeffshee commented Sep 9, 2022

@VarLad It might be. However, Gstreamer integration in Gtk4 seems half-baked, based on my experience. If we really want to switch to Gstreamer, I think we should first make a minimal Gstreamer video player (in Gtk4 ofcuz) and do some unit testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants