New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call to Hedwig.Robot.handle_connect on :connected callback #4

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@PhillippOhlandt
Contributor

PhillippOhlandt commented Jan 7, 2018

Otherwise the handle_connect/1 function in the robot module never gets called and the bot won't be registered by it's name (when using the default robot module setup).

PhillippOhlandt added some commits Jan 7, 2018

@PhillippOhlandt

This comment has been minimized.

Show comment
Hide comment
@PhillippOhlandt

PhillippOhlandt Jan 8, 2018

Contributor

@jeffweiss I resolved the merge conflicts using GitHubs UI. The PR diff looks good to me, but I still see the This branch has conflicts that must be resolved message.

Contributor

PhillippOhlandt commented Jan 8, 2018

@jeffweiss I resolved the merge conflicts using GitHubs UI. The PR diff looks good to me, but I still see the This branch has conflicts that must be resolved message.

jeffweiss added a commit that referenced this pull request Jan 8, 2018

Merge pull request #4 from PhillippOhlandt/patch-1
Add call to Hedwig.Robot.handle_connect on :connected callback
@PhillippOhlandt

This comment has been minimized.

Show comment
Hide comment
@PhillippOhlandt

PhillippOhlandt Jan 8, 2018

Contributor

I did it again and now it works, lol.

EDIT: Or it's because you merged it before I resolved the conflicts again.

Contributor

PhillippOhlandt commented Jan 8, 2018

I did it again and now it works, lol.

EDIT: Or it's because you merged it before I resolved the conflicts again.

@jeffweiss

This comment has been minimized.

Show comment
Hide comment
@jeffweiss

jeffweiss Jan 8, 2018

Owner

Merged via 7855161

Owner

jeffweiss commented Jan 8, 2018

Merged via 7855161

@jeffweiss jeffweiss closed this Jan 8, 2018

@PhillippOhlandt PhillippOhlandt deleted the PhillippOhlandt:patch-1 branch Jan 8, 2018

@jeffweiss

This comment has been minimized.

Show comment
Hide comment
@jeffweiss

jeffweiss Jan 8, 2018

Owner

Deployed in 0.1.4. Thanks!

Owner

jeffweiss commented Jan 8, 2018

Deployed in 0.1.4. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment