Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Safari uploads, closes #37. Please help review. #184

Merged
merged 7 commits into from Mar 18, 2012

Conversation

Projects
None yet
3 participants
Contributor

mixonic commented Mar 15, 2012

Wow, what a night!

In Safari, FileReader was dropped in 5.1.something. There is also some problem with multi-part uploads in Safari 5. FileReader looks like it's probably on the way out anyway (in the next few years).

Anyway, this uses FormBuilder and Safari's native binary data ajax posts.

I considered the alternative of just building jQuery-File-Upload into Mercury. Honestly, I think that or plupload would be a great idea instead of rolling something custom. With jQuery-File-Upload, we also get a lightweight way to offer upload forms instead of just the tough-to-discover-and-learn drag and drop.

This is good in Chrome 18, Firefox 11, and Safari 5.1. Please, give it a test in another browser and see if any other version does not work properly.

Good job! I confirm this works in mentioned Chrome and Safari versions on both Mac and Windows. Latest Safari 5.3 and Chrome 19.0.1 dev OK. The problem with Firefox from #145 still persists even though I upgraded to version 11.

Now it works in Firefox without problems. I even spinned up by old Windows XP PC and tried it on Firefox 6. Everything works fine. Remarkably good work. A big thank to you @mixonic!

Owner

jejacks0n commented Mar 18, 2012

Thanks man!

@jejacks0n jejacks0n added a commit that referenced this pull request Mar 18, 2012

@jejacks0n jejacks0n Merge pull request #184 from mixonic/safari_uploads
Safari uploads, closes #37. Please help review.
e435ad6

@jejacks0n jejacks0n merged commit e435ad6 into jejacks0n:master Mar 18, 2012

Contributor

mixonic commented Mar 18, 2012

w00t!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment