Add coverage threshold checking #52

Closed
dkubb opened this Issue Apr 11, 2013 · 6 comments

Projects

None yet

3 participants

Contributor
dkubb commented Apr 11, 2013

I would like to use istanbul's check-coverage feature, but I think it requires the presence of the coverage.json file. It looks like teabag creates it in a temp directory, which is cleaned up after the coverage report is generated.

Would you accept a patch to copy this file into the coverage/ directory after the report is generated? I believe this should allow me to then run istanbul check-coverage <options> to do things like checking that thresholds were not exceeded.

Owner

Yes, we would.

Owner

Thanks for your other pull request.. I'll try and get to fixing the build this weekend and get the pull requests merged in.

Owner

The build is fixed. Are you planning on doing this?

Contributor
dkubb commented Apr 12, 2013

@jejacks0n it probably won't be right away. I made a note in our project tracker to revisit this in a later sprint (for us), assuming someone hasn't beat me to it.

DannyJF commented Oct 10, 2013

I'd love this feature as well.

Owner

This is in now btw. Thanks to @trevmex.

@jejacks0n jejacks0n closed this Dec 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment