Skip to content

Commit fc1a69d

Browse files
James BottomleyJames Bottomley
authored andcommitted
Update TLS connection code to modern protocols
The allowed protocols list is so dated that there's no overlap with the protocols modern systems would wish to communicate over, so do a complete refresh to TLS v1.1 v1.2 and v1.3 Change-Id: I56288928e06fa05d074fe4c4dd04109cf6cb7d72 Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
1 parent d0a7687 commit fc1a69d

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

java/gov/nist/javax/sip/SipStackImpl.java

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -466,22 +466,34 @@ public class SipStackImpl extends SIPTransactionStack implements
466466
// RFC3261: TLS_RSA_WITH_AES_128_CBC_SHA MUST be supported
467467
// RFC3261: TLS_RSA_WITH_3DES_EDE_CBC_SHA SHOULD be supported for backwards
468468
// compat
469+
// JEJB: Add modern protocols (not necessary because this is server only)
469470
private String[] cipherSuites = {
470471
"TLS_RSA_WITH_AES_128_CBC_SHA", // AES difficult to get with
472+
// Additions for sip stack upgrades
473+
"TLS_AES_128_GCM_SHA256",
474+
"TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA",
475+
"TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
476+
"TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA",
477+
"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
471478
// c++/Windows
472479
// "TLS_RSA_WITH_3DES_EDE_CBC_SHA", // Unsupported by Sun impl,
473-
"SSL_RSA_WITH_3DES_EDE_CBC_SHA", // For backwards comp., C++
480+
// "SSL_RSA_WITH_3DES_EDE_CBC_SHA", // For backwards comp., C++
474481

475482
// JvB: patch from Sebastien Mazy, issue with mismatching
476483
// ciphersuites
477-
"TLS_DH_anon_WITH_AES_128_CBC_SHA",
478-
"SSL_DH_anon_WITH_3DES_EDE_CBC_SHA", };
484+
// "TLS_DH_anon_WITH_AES_128_CBC_SHA",
485+
// "SSL_DH_anon_WITH_3DES_EDE_CBC_SHA",
486+
};
479487

488+
// JEJB: update to modern TLS protocols, remove deprecated ones
480489
// Supported protocols for TLS client: can be overridden by application
481490
private String[] enabledProtocols = {
482-
"SSLv3",
483-
"SSLv2Hello",
484-
"TLSv1"
491+
//"SSLv3",
492+
//"SSLv2Hello",
493+
//"TLSv1",
494+
"TLSv1.1",
495+
"TLSv1.2",
496+
"TLSv1.3",
485497
};
486498

487499
/**

0 commit comments

Comments
 (0)