Use git remote url to determine nwo #45
Conversation
| end | ||
|
|
||
| it "grabs the git nwo from an HTTPS url" do | ||
| subject.class.any_instance.stub(:git_remote_url) { "htps://github.com/foo/bar" } |
There was a problem hiding this comment.
allow(subject).to receive(:git_remote_url).and_return("https://github.com/foo/bar")
|
Ahh. Google was failing me. Thanks @parkr fixed. |
|
To note, my motivation for this, is if this plugin is included by default via the pages gem, that means that without this fix, sites will fail to build by default, since they don't specify a repository in the config. |
| end | ||
|
|
||
| it "retrieves the git remote" do | ||
| expect(subject.send(:git_remote_url)).to include("jekyll/github-metadata") |
There was a problem hiding this comment.
This seems to fail. Think it's hitting your stub on line 23?
https://travis-ci.org/jekyll/github-metadata/jobs/117149521#L232
…t-url is too new Travis's git doesn't have it, so others' git setups likely won't either. git/git@96f78d3#diff-388838443870b4d1c62785151773c6ff
|
@benbalter Due to git/git@96f78d3#diff-388838443870b4d1c62785151773c6ff being relatively new, I think going the route of the olden days ( |
|
@jekyllbot: merge |
|
What version is this fixed in? I don't see a milestone marked on the GitHub issue. |
|
Looks like this is still a problem with auto-rebuilds when running |
- need to set 'repository: simonis/cl4cds' if there's no git available or git is too old to understand 'git remote get-url origin' (see jekyll/github-metadata#45) - have to use jekyll/jekyll:latest Docker image as jekyll/jekyll:pages doesn't seem to work anymore (see envygeeks/jekyll-docker#198)
Fixes #44
@parkr any idea how to properly mock the
git_remote_urlmethod?