From a52f393d4cf09c34e95d9411ab95a6bba48ba455 Mon Sep 17 00:00:00 2001 From: mertkahyaoglu Date: Thu, 19 Mar 2020 22:34:33 +0300 Subject: [PATCH] Check file type before accessing its extension --- src/components/FilePreview.js | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/components/FilePreview.js b/src/components/FilePreview.js index 2a76f14ea..fbb5dbb8b 100644 --- a/src/components/FilePreview.js +++ b/src/components/FilePreview.js @@ -34,11 +34,20 @@ export default class FilePreview extends Component { } } + get isImageFile() { + const { + file: { type, extname }, + } = this.props; + if (type === 'directory') { + return false; + } + + return /png|jpg|gif|jpeg|svg|ico/i.test(extname.substring(1)); + } + render() { const { onClick, file, splat } = this.props; - const extension = file.extname.substring(1); - const image = /png|jpg|gif|jpeg|svg|ico/i.test(extension); - const node = image ? ( + const node = this.isImageFile ? ( {file.relative_path} ) : (