New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable posts limit, instead of hardcoded limit 10 posts #213

Closed
bittlingmayer opened this Issue Mar 1, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@bittlingmayer
Copy link

bittlingmayer commented Mar 1, 2018

feed.xml:

{% for post in posts limit: 10 %}
   ...

It would be nice if this were configurable.

Another option that would work is to generate a feed for the last 10 and eg 100 and 1000. This would provide some of the value of a URL parameter while still being doable in a static site.

@pathawks

This comment has been minimized.

Copy link
Member

pathawks commented Mar 1, 2018

See also: #192 #56 #40

@bittlingmayer

This comment has been minimized.

Copy link

bittlingmayer commented Mar 1, 2018

@pathawks Re the smart union of last n posts and last m hours mentioned in #193:

For last m hours you could take same approach of generating multiple options.

/feed.1h.xml, /feed.2d.xml, /feed.7d.xml

If you combined the two heuristics, and the number of generated feeds blows up to a few dozen, I assume it would still be reasonably cheap.

@pathawks

This comment has been minimized.

Copy link
Member

pathawks commented Mar 1, 2018

Do any feed readers support paginated Atom feeds?

http://www.ibm.com/developerworks/library/x-tipatom2/index.html

@bittlingmayer

This comment has been minimized.

Copy link

bittlingmayer commented Mar 2, 2018

I assume so, but I am the wrong person to answer that. For my client, and maybe for others, what matters how easy it is to consume programmatically in a mobile app, so you could look at the top Android libs.

But note that pagination is not being requested here, adds complexity and is usually not used much.

@pathawks

This comment has been minimized.

Copy link
Member

pathawks commented Mar 2, 2018

But note that pagination is not being requested here, adds complexity and is usually not used much.

I understand, but I think the case against a configurable feed limit has been stated already, so I am trying to think of a way to provide more posts without adding another config option.

@jekyllbot

This comment has been minimized.

Copy link
Contributor

jekyllbot commented Apr 30, 2018

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@jekyllbot jekyllbot added the stale label Apr 30, 2018

@pathawks pathawks closed this Apr 30, 2018

@bittlingmayer

This comment has been minimized.

Copy link

bittlingmayer commented May 2, 2018

@pathawks Follow-up: we worked around this by dropping jekyll-feed and implementing our own layout.

@jekyllbot jekyllbot removed the stale label May 2, 2018

@jekyll jekyll locked as resolved and limited conversation to collaborators May 3, 2018

@pathawks pathawks added the duplicate label May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.