New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double // in feed.xml #63

Closed
dentarg opened this Issue Sep 11, 2015 · 6 comments

Comments

Projects
None yet
6 participants
@dentarg
Copy link

dentarg commented Sep 11, 2015

with this in my _config.yml

baseurl:      /
url:          https://my.site.com

feed.xml will render as

...

<link href="https://my.site.com//" rel="alternate" type="text/html" />

...

<link href="https://my.site.com//2015/07/01/foo-bar/" rel="alternate" type="text/html" title="Foo Bar" />

...

<id>https://my.site.com//2015/07/01/foo-bar</id>
<content type="html" xml:base="https://my.site.com//2015/07/01/foo-bar/">

I could change the configuration to baseurl: "", but wouldn't that make the {{ site.baseurl }} rather useless? You would always have to use it like <a href="{{ site.baseurl }}/">. But maybe that's the Jekyll way?

@benbalter

This comment has been minimized.

Copy link
Contributor

benbalter commented Sep 11, 2015

/cc @parkr for his favorite topic, the (mis)use of baseurl. 😸

@pathawks

This comment has been minimized.

Copy link
Member

pathawks commented Sep 11, 2015

But maybe that's the Jekyll way?

Yup.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Sep 11, 2015

baseurl: "" and baseurl: "/" should be handled identically by Jekyll. Perhaps prepend is just too simple for this complicated solution of path joining.

That said, I know baseurl is meant to be either "" or "/some-base-path", i.e. never ending in a /. So maybe this is a case of (mis)use gone awry yet again.

@dentarg

This comment has been minimized.

Copy link

dentarg commented Sep 11, 2015

Thanks for clarifying. I've made the switch to baseurl: "" and {{ site.baseurl }}/ for our Jekyll setup.

I let you decide if you want to close or leave this issue open.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Sep 11, 2015

Let's close it. Thanks for reporting! Hopefully this conversation will help others in the future.

@parkr parkr closed this Sep 11, 2015

@AuyaJackie

This comment has been minimized.

Copy link

AuyaJackie commented Sep 12, 2015

Hello!

Im a green student, Im already try more time also lose!

azure ...Im very thank them help me upload the code my HitGub....but Im still can build up a website builder!

Can you tell me , have the most of simple action to install thw websitebulder😭😭😭😭😭

傳送自 iOS 版 myMail

2015年9月12日 星期六 上午12:49 +0800 寄件人 Ben Balter notifications@github.com:

/cc @parkr for his favorite topic, the (mis)use of baseurl.

Reply to this email directly or view it on GitHub .

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.