Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress import is improperly encoding HTML end tags #254

Closed
richardtallent opened this issue May 22, 2016 · 4 comments

Comments

@richardtallent
Copy link
Contributor

@richardtallent richardtallent commented May 22, 2016

I just imported my Wordpress site (self-hosted) and all HTML end tags had the "/" replaced with "/", which of course makes them ever so slightly less useful as HTML end tags.

I commented the following line in wordpress.rb and it worked, but since I don't know the background of why this line was added in the first place (there must be a reason), I didn't want to send a naive pull request:

text.gsub!("/", "/")

Using the latest Jeckyll, jeckyll-import, Wordpress, etc.

@jekyllbot

This comment has been minimized.

Copy link
Contributor

@jekyllbot jekyllbot commented Jun 22, 2016

This issue has been automatically marked as stale because it has not been commented on for at least
one month.

The resources of the Jekyll team are limited, and so we are asking for your help.

If you can still reproduce this error on the 3.1-stable or master branch,
please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced
hooks which provide convenient access points throughout
the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be
built as a plugin, then please provide more information about why in order to keep this issue open.

Thank you for all your contributions.

@jekyllbot jekyllbot added the stale label Jun 22, 2016
@pathawks pathawks changed the title Wordpress import is improperly encoding HTML end tags WordPress import is improperly encoding HTML end tags Jun 22, 2016
@parkr

This comment has been minimized.

Copy link
Member

@parkr parkr commented Jun 22, 2016

@richardtallent Hey, this has been around ever since the beginning of this repo, which means it was in Jekyll proper before that (when importers were a part of the core repo).

Spelunking through history, that file was removed in jekyll/jekyll#793 Looking at the git blame for that file, it turns out @mattr- actually added that in jekyll/jekyll@8fb4e8f. He would be better suited to help you understand why it was added 😄

@jekyllbot jekyllbot removed the stale label Jun 22, 2016
@jekyllbot

This comment has been minimized.

Copy link
Contributor

@jekyllbot jekyllbot commented Aug 22, 2016

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@jekyllbot jekyllbot added the stale label Aug 22, 2016
@jekyllbot jekyllbot closed this Oct 22, 2016
@richardtallent

This comment has been minimized.

Copy link
Contributor Author

@richardtallent richardtallent commented Jan 27, 2017

I haven't had a chance to look into Jekyll more until now. Reinstalled all the latest tooling, and I'm seeing the same problem now as before. Haven't tried the same fix yet, but wanted to get the ball rolling again. This seems like a pretty major issue for anyone upgrading from WordPress who uses anything more than the most trivial of formatting.

@jekyllbot jekyllbot removed the stale label Jan 27, 2017
richardtallent added a commit to richardtallent/jekyll-import that referenced this issue Jan 28, 2017
@jekyll jekyll locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.