New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer dependencies mechanism #26

Closed
j15e opened this Issue May 23, 2013 · 5 comments

Comments

Projects
None yet
5 participants
@j15e

j15e commented May 23, 2013

What do you think of improving the way importer dependencies are deal with?

https://github.com/jekyll/jekyll-import/blob/master/lib/jekyll/jekyll-import/wordpress.rb#L6

Currently, when you follow the instructions on jekyll migration doc you are not told about having to install importers dependencies manually which results in errors like :

LoadError: cannot load such file -- sequel

Install sequel. Then :

Sequel::AdapterNotFound: LoadError: cannot load such file -- mysql

Install MySQL. Then it's okay.

It's not that complicated and I found out the solution, but I think there is room for improvement for the migration to be smoother for newbies.

I suggest the following ideas :

  • Add all importer dependencies to jekyll-import runtime dependencies (sounds stupid)
  • Create a gem out of each importer so we could specify dependencies in the gemspec
  • Add a warning to user about having to install each dependencies

I can help providing theses solutions, but would like to have your input first. Maybe a better solutions I haven't think of.

@parkr

This comment has been minimized.

Member

parkr commented May 23, 2013

This is a great point! Each importer requires the gems it needs separately. I'd love to be able to package everything together into this one gem so option 2 is less appealing to me, though I'm certainly open to it if it's the best solution.

I like option three the most. We can have a begin ... rescue LoadError ... end block at the top that lists all the gem dependencies for the migrator so it isn't a multi-step trial-and-error problem as you encountered.

I'd be interested to hear what @mattr- thinks.

@j15e

This comment has been minimized.

j15e commented May 23, 2013

I found a discussion here, seems like begin/rescue is the best option at this moment :

rubygems/rubygems#346

@wizonesolutions

This comment has been minimized.

wizonesolutions commented Oct 10, 2013

Seems like all the action is in #58 now?

@mattr-

This comment has been minimized.

Member

mattr- commented Oct 11, 2013

begin/rescue is our best option here I think.

albertogg added a commit to albertogg/jekyll-import that referenced this issue Oct 27, 2013

Fix with suggestions.
Second pass fixes using parkr suggestions. this commit fixes jekyll#26 and fixes jekyll#58 issues.
@parkr

This comment has been minimized.

Member

parkr commented Nov 9, 2013

Fixed with all my changes since yesterday and thursday

@parkr parkr closed this Nov 9, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.