Join GitHub today
Only complete write_post on Tumblr posts w/ non-nil content #118
Answers to questions on Tumblr appear as posts without content.
f.puts post[:header].to_yaml + "---\n" + nil
Perhaps we do want to add these posts in which case we'll at least have to ensure we don't attempt to append
f.puts post[:header].to_yaml + "---\n" + (content or "")
Thanks for the heads up @mattr-. I will pay attention to try issuing changes in separate pull requests. How would you go about proposing a change like this one? The shoulda bump was necessary for me to be able to pass my tests. Separate pull-requests would introduce the possibility of the codebase being modified without the gem deps being updated as well to support the changes (if the code change pull request were to be accepted before the gemspec change pull request). Furthermore I have no idea if Travis CI would have thrown up over my code if shoulda hadn't been updated first. Basing my changes on a pending pull-request could be a solution, but if these changes are in the same branch Github will consolidate it into one pull-request. Should I have proposed the shoulda change in a separate branch? Or do you mean something else?
I totally understand the problem with the dependencies here. If I were doing it, I would have split the shoulda bump into a different branch, made sure all the tests pass, and then make that a pull request.
I would have also split the support for the answer format into a separate branch and pull request too.
I want to stress that this is just one way of working and that there's nothing wrong with working a different way. As project maintainers, we ask for smaller, more focused contributions simply because they're easier for us to see what's happening to the code and digest vs. larger pull requests that do many things at once.