New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto-paragraph wordpress convention #125

Merged
merged 1 commit into from Feb 13, 2014

Conversation

Projects
None yet
4 participants
@miguelff
Contributor

miguelff commented Jan 23, 2014

This PR fixes #107

I have migrated the nasty wpautop helper to ruby in order to import posts as they are rendered in wordpress (i.e. with automatic paragraph wrapping)

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jan 29, 2014

Member

There's no reason to duplicate the code for wpautop in each importer if it's in it's own class or module. Could you please fix that up?

Member

mattr- commented Jan 29, 2014

There's no reason to duplicate the code for wpautop in each importer if it's in it's own class or module. Could you please fix that up?

@miguelff

This comment has been minimized.

Show comment
Hide comment
@miguelff

miguelff Jan 29, 2014

Contributor

Sure, I thought importers as self-contained.

Contributor

miguelff commented Jan 29, 2014

Sure, I thought importers as self-contained.

@miguelff

This comment has been minimized.

Show comment
Hide comment
@miguelff

miguelff Jan 29, 2014

Contributor

Would you prefer to have the function as part of a util module included in both importers, or make one of the importers depend on the other?

Contributor

miguelff commented Jan 29, 2014

Would you prefer to have the function as part of a util module included in both importers, or make one of the importers depend on the other?

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jan 29, 2014

Member

A utility module would be best from my point of view.

Member

mattr- commented Jan 29, 2014

A utility module would be best from my point of view.

@miguelff

This comment has been minimized.

Show comment
Hide comment
@miguelff

miguelff Jan 29, 2014

Contributor

I have made the changes and squashed the commits to keep the history clean. Let's see if travis doesn't complain.

Contributor

miguelff commented Jan 29, 2014

I have made the changes and squashed the commits to keep the history clean. Let's see if travis doesn't complain.

@parkr

View changes

Show outdated Hide outdated lib/jekyll-import.rb
@@ -7,6 +7,8 @@
require 'jekyll-import/importer'
require 'jekyll-import/importers'
autoload 'Util', 'jekyll-import/util'

This comment has been minimized.

@parkr

parkr Jan 29, 2014

Member

It'd be great if this Util object were housed within JekyllImport, rather than be on the main Object.

@parkr

parkr Jan 29, 2014

Member

It'd be great if this Util object were housed within JekyllImport, rather than be on the main Object.

Support auto-paragraph wordpress convention
Host Util inside Jekyll-import
@miguelff

This comment has been minimized.

Show comment
Hide comment
@miguelff

miguelff Feb 10, 2014

Contributor

I think now it's ready, I have hosted Util inside JekillImport

Sorry for the lag guys, I've been pretty busy these days.

Contributor

miguelff commented Feb 10, 2014

I think now it's ready, I have hosted Util inside JekillImport

Sorry for the lag guys, I've been pretty busy these days.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 10, 2014

Member

LGTM! @mattr-?

Member

parkr commented Feb 10, 2014

LGTM! @mattr-?

@parkr parkr added this to the v0.2.0 milestone Feb 10, 2014

mattr- added a commit that referenced this pull request Feb 13, 2014

mattr- added a commit that referenced this pull request Feb 13, 2014

Merge pull request #125 from miguelff/master
Support auto-paragraph wordpress convention

@mattr- mattr- merged commit a1e1b68 into jekyll:master Feb 13, 2014

1 check passed

default The Travis CI build passed
Details
@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Feb 13, 2014

Member

Cool. Thank you for the contribution! ❤️

Member

mattr- commented Feb 13, 2014

Cool. Thank you for the contribution! ❤️

@miguelff

This comment has been minimized.

Show comment
Hide comment
@miguelff

miguelff Feb 13, 2014

Contributor

You're welcome! 🌈

Contributor

miguelff commented Feb 13, 2014

You're welcome! 🌈

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.