New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `socket` option to the WordPress importer. #140

Merged
merged 1 commit into from May 20, 2014

Conversation

Projects
None yet
3 participants
@lucasmazza
Contributor

lucasmazza commented May 17, 2014

Required for non standard MySQL installs (i.e. boxen).

@@ -103,7 +106,7 @@ def self.process(opts)
FileUtils.mkdir_p("_posts")
db = Sequel.mysql2(options[:dbname], :user => options[:user], :password => options[:pass],
:host => options[:host], :encoding => 'utf8')
:socket => options[:socket], :host => options[:host], :encoding => 'utf8')

This comment has been minimized.

@parkr

parkr May 18, 2014

Member

Doesn't the socket override the user:password@host?

@parkr

parkr May 18, 2014

Member

Doesn't the socket override the user:password@host?

This comment has been minimized.

@lucasmazza

lucasmazza May 18, 2014

Contributor

No, proper credentials and host info are still required.

@lucasmazza

lucasmazza May 18, 2014

Contributor

No, proper credentials and host info are still required.

This comment has been minimized.

@parkr

parkr May 18, 2014

Member

If socket is nil, you mean?

@parkr

parkr May 18, 2014

Member

If socket is nil, you mean?

This comment has been minimized.

@lucasmazza

lucasmazza May 18, 2014

Contributor

No, even when socket is present.

@lucasmazza

lucasmazza May 18, 2014

Contributor

No, even when socket is present.

parkr added a commit that referenced this pull request May 20, 2014

@parkr parkr merged commit cd94425 into jekyll:master May 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 20, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.