New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the CSV importer to skip writing front matter #143

Merged
merged 2 commits into from May 23, 2014

Conversation

Projects
None yet
4 participants
@mattr-
Member

mattr- commented May 23, 2014

As mentioned in #142, it might be useful to be able to not write front matter to a post if the imported data already has front matter in it. This pull request provides an option that allows users to not write the default front matter.

mattr- added some commits May 23, 2014

Add an option to exclude front matter
The front matter will be expected to be in the body of the post
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 23, 2014

Member

Looks great to me! :shipit:

Member

parkr commented May 23, 2014

Looks great to me! :shipit:

mattr- added a commit that referenced this pull request May 23, 2014

Merge pull request #143 from jekyll/csv-no-frontmatter
Allow the CSV importer to skip writing front matter

@mattr- mattr- merged commit 124ed74 into master May 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@mattr- mattr- deleted the csv-no-frontmatter branch May 23, 2014

@jcyin1

This comment has been minimized.

Show comment
Hide comment
@jcyin1

jcyin1 May 23, 2014

Hello, I'm new to Github so I'm not quite sure but I see above that mattr closed something 2 hours ago. Does this mean the modification is finished or still ongoing? Sorry for the noob question

jcyin1 commented May 23, 2014

Hello, I'm new to Github so I'm not quite sure but I see above that mattr closed something 2 hours ago. Does this mean the modification is finished or still ongoing? Sorry for the noob question

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 23, 2014

Member

Totally fine! The modification has been merged to the master branch, but has not yet been released. In order for you to use it, we will have to release a new version of the gem.

Member

parkr commented May 23, 2014

Totally fine! The modification has been merged to the master branch, but has not yet been released. In order for you to use it, we will have to release a new version of the gem.

parkr added a commit that referenced this pull request May 23, 2014

@jcyin1

This comment has been minimized.

Show comment
Hide comment
@jcyin1

jcyin1 May 23, 2014

Oh okay I see. Would you have an approximate ETA for the new release?

jcyin1 commented May 23, 2014

Oh okay I see. Would you have an approximate ETA for the new release?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 27, 2014

Member

It's been pushed! v0.3.0.

Member

parkr commented May 27, 2014

It's been pushed! v0.3.0.

@jcyin1

This comment has been minimized.

Show comment
Hide comment
@jcyin1

jcyin1 May 27, 2014

Thanks, just downloaded it. Works perfectly! :)

jcyin1 commented May 27, 2014

Thanks, just downloaded it. Works perfectly! :)

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 27, 2014

Member

Glad to hear that!

Member

parkr commented May 27, 2014

Glad to hear that!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.