New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add taxonomy ('tags') to Drupal6 migration #15

Merged
merged 4 commits into from Jun 30, 2013

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Mar 17, 2013

Extracts Drupal 6 tags and outputs as Jekyll categories.

Originally submitted by @clayt0nk in jekyll/jekyll#740

parkr added a commit that referenced this pull request Jun 30, 2013

Merge pull request #15 from jekyll/drupal-add-tags
Add taxonomy ('tags') to Drupal6 migration

@parkr parkr merged commit 7b3164f into master Jun 30, 2013

@parkr parkr deleted the drupal-add-tags branch Jun 30, 2013

parkr added a commit that referenced this pull request Jun 30, 2013

@jinghao

This comment has been minimized.

Show comment
Hide comment
@jinghao

jinghao Jul 15, 2013

Contributor

Hm, this seems to have introduced a number of issues. One of them I fixed in #41 and @parkr merged. Another is that this now causes posts without tags to not get migrated (silently). Notice how you use a JOIN instead of LEFT OUTER JOIN. Lastly, tags/categories with spaces in them are not handled.

I'll see what I can do about the second and third problems.

Contributor

jinghao commented on 0b33a12 Jul 15, 2013

Hm, this seems to have introduced a number of issues. One of them I fixed in #41 and @parkr merged. Another is that this now causes posts without tags to not get migrated (silently). Notice how you use a JOIN instead of LEFT OUTER JOIN. Lastly, tags/categories with spaces in them are not handled.

I'll see what I can do about the second and third problems.

This comment has been minimized.

Show comment
Hide comment
@jinghao

jinghao Jul 15, 2013

Contributor

Fixed the issues in #42

Contributor

jinghao replied Jul 15, 2013

Fixed the issues in #42

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.