New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blogger (blogspot.com) importer #162

Merged
merged 16 commits into from Sep 19, 2014

Conversation

Projects
None yet
3 participants
@cat-in-136
Contributor

cat-in-136 commented Aug 31, 2014

I created a Blogger-to-Jekyll importer.

$ jekyll import blogger --source /path/to/blog-MM-DD-YYYY.xml

Would you capture my importer?

@parkr

View changes

Show outdated Hide outdated lib/jekyll-import/importers/blogger.rb
@@ -0,0 +1,263 @@
require 'rexml/streamlistener'

This comment has been minimized.

@parkr

parkr Aug 31, 2014

Member

This needs to be placed in require_deps.

@parkr

parkr Aug 31, 2014

Member

This needs to be placed in require_deps.

This comment has been minimized.

@cat-in-136

cat-in-136 Aug 31, 2014

Contributor

Removing the line cause an error on include REXML::StreamListener on BloggerAtomStreamListener class.

I have no idea how to do same without require...

@cat-in-136

cat-in-136 Aug 31, 2014

Contributor

Removing the line cause an error on include REXML::StreamListener on BloggerAtomStreamListener class.

I have no idea how to do same without require...

@parkr

View changes

Show outdated Hide outdated lib/jekyll-import/importers/blogger.rb
end
end
end

This comment has been minimized.

@parkr

parkr Aug 31, 2014

Member

Please remove all lines below this one.

@parkr

parkr Aug 31, 2014

Member

Please remove all lines below this one.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 31, 2014

Member

Looks great! I'd gladly merge if you address my 2 comments and fix the tests, please. Thanks!

Member

parkr commented Aug 31, 2014

Looks great! I'd gladly merge if you address my 2 comments and fix the tests, please. Thanks!

cat-in-136 added some commits Aug 31, 2014

fix in test/test_blogger_importer.rb
Two 'the in-elem-entry-to-post-data converter should raise an error if original_url not exists.' exists (duplicated).
So the 2nd test is replaced with '...should raise an error if non-post-kind not exists'.
In addition, fix the 1st test.
@cat-in-136

This comment has been minimized.

Show comment
Hide comment
@cat-in-136

cat-in-136 Sep 6, 2014

Contributor

I wonder if the changeset cd3980a is OK wrt coding rule...

Contributor

cat-in-136 commented Sep 6, 2014

I wonder if the changeset cd3980a is OK wrt coding rule...

@parkr parkr merged commit db474c9 into jekyll:master Sep 19, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 19, 2014

Member

It is perfect! Just so you know, I'll be coming back to you if people come asking about this code 😄 Thanks so much for your contribution!!

Member

parkr commented Sep 19, 2014

It is perfect! Just so you know, I'll be coming back to you if people come asking about this code 😄 Thanks so much for your contribution!!

parkr added a commit that referenced this pull request Sep 19, 2014

parkr added a commit that referenced this pull request Sep 19, 2014

parkr added a commit that referenced this pull request Apr 14, 2016

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.