New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for behance import file #167

Merged
merged 2 commits into from Nov 3, 2014

Conversation

Projects
None yet
3 participants
@adrianjonmiller
Contributor

adrianjonmiller commented Nov 3, 2014

Changed the fetch file to just accept the token. Can now reuse the function in the loop to make a call for each project associated with the behance account.

Fixes for behance import file
Changed the fetch file to just accept the token. Can now reuse the function in the loop to make a call for each project associated with the behance account.
Show outdated Hide outdated lib/jekyll-import/importers/behance.rb
}
header = details
header["layout"] = "post"

This comment has been minimized.

@parkr

parkr Nov 3, 2014

Member

No title here?

@parkr

parkr Nov 3, 2014

Member

No title here?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 3, 2014

Member

Looking good! Should the title be put back into the header hash?

Member

parkr commented Nov 3, 2014

Looking good! Should the title be put back into the header hash?

@adrianjonmiller

This comment has been minimized.

Show comment
Hide comment
@adrianjonmiller

adrianjonmiller Nov 3, 2014

Contributor

The name is included as part of the details. In my template page.name pulls the project name, but I don't see a problem with including it the title as well. Up to you.

Contributor

adrianjonmiller commented Nov 3, 2014

The name is included as part of the details. In my template page.name pulls the project name, but I don't see a problem with including it the title as well. Up to you.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 3, 2014

Member

The name is included as part of the details. In my template page.name pulls the project name, but I don't see a problem with including it the title as well. Up to you.

The Jekyll convention is to use title, so let's move name to title (name is reserved for another purpose).

Member

parkr commented Nov 3, 2014

The name is included as part of the details. In my template page.name pulls the project name, but I don't see a problem with including it the title as well. Up to you.

The Jekyll convention is to use title, so let's move name to title (name is reserved for another purpose).

@adrianjonmiller

This comment has been minimized.

Show comment
Hide comment
@adrianjonmiller

adrianjonmiller Nov 3, 2014

Contributor

Ok. Updated the file back to the original header format.

Contributor

adrianjonmiller commented Nov 3, 2014

Ok. Updated the file back to the original header format.

parkr added a commit that referenced this pull request Nov 3, 2014

@parkr parkr merged commit 8f0492a into jekyll:master Nov 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Nov 3, 2014

@adrianjonmiller adrianjonmiller deleted the adrianjonmiller:patch-1 branch Nov 3, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.