New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tumblr.rb #168

Merged
merged 2 commits into from Dec 3, 2014

Conversation

Projects
None yet
3 participants
@nikkortumblr
Contributor

nikkortumblr commented Nov 19, 2014

checking for empty title

Update tumblr.rb
checking for empty title
Show outdated Hide outdated lib/jekyll-import/importers/tumblr.rb
@@ -138,6 +138,9 @@ def self.post_to_hash(post, format)
title = post["question"]
content = post["answer"]
end
if title == ""

This comment has been minimized.

@parkr

parkr Nov 19, 2014

Member

Let's use the built-in title.empty? and use a post-if:

title = "no title" if title.empty?
@parkr

parkr Nov 19, 2014

Member

Let's use the built-in title.empty? and use a post-if:

title = "no title" if title.empty?
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 19, 2014

Member

Thanks!

Member

parkr commented Nov 19, 2014

Thanks!

parkr added a commit that referenced this pull request Dec 3, 2014

@parkr parkr merged commit 0825ee4 into jekyll:master Dec 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Dec 3, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.