New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using nil for wordpress default socket #170

Merged
merged 1 commit into from Dec 3, 2014

Conversation

Projects
None yet
3 participants
@twohlix
Contributor

twohlix commented Dec 3, 2014

This PR is to fix issue #161 for jekyll-import. The default socket of an empty string causes issues while passing nil as a default does not.

I could not come up with an automated test for this as we'd need a test db to use Sequel with. You can recreate this issue on command line with an error occuring pre-PR with:

ruby -rubygems -e 'require "jekyll-import";
  JekyllImport::Importers::WordPress.run({
  "dbname" => "your_db",
  "user" => "root"
})'

Using the change in the PR the above will work.

@parkr parkr merged commit 375bf74 into jekyll:master Dec 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 3, 2014

Member

Thank you!

Member

parkr commented Dec 3, 2014

Thank you!

parkr added a commit that referenced this pull request Dec 3, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.