New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Drupal 7 body_summary field as an excerpt if it's available #176

Merged
merged 1 commit into from Jan 2, 2015

Conversation

Projects
None yet
3 participants
@jessepinho
Contributor

jessepinho commented Jan 2, 2015

No description provided.

'layout' => 'post',
'title' => title.to_s,
'created' => created,
}.delete_if { |k,v| v.nil? || v == ''}.to_yaml

This comment has been minimized.

@jessepinho

jessepinho Jan 2, 2015

Contributor

These lines were indented one extra space so I fixed it—hence the strange diff.

@jessepinho

jessepinho Jan 2, 2015

Contributor

These lines were indented one extra space so I fixed it—hence the strange diff.

'layout' => 'post',
'title' => title.to_s,
'created' => created,
'excerpt' => summary

This comment has been minimized.

@parkr

parkr Jan 2, 2015

Member

Should summary be cast to a string? What are its expected values?

@parkr

parkr Jan 2, 2015

Member

Should summary be cast to a string? What are its expected values?

This comment has been minimized.

@jessepinho

jessepinho Jan 2, 2015

Contributor

It can't hurt; but the body_summary field from the database is of type LONGTEXT, so I'm not sure it's necessary (especially considering created isn't being cast to an integer—it's just being trusted as a valid integer value).

@jessepinho

jessepinho Jan 2, 2015

Contributor

It can't hurt; but the body_summary field from the database is of type LONGTEXT, so I'm not sure it's necessary (especially considering created isn't being cast to an integer—it's just being trusted as a valid integer value).

This comment has been minimized.

@jessepinho

jessepinho Jan 2, 2015

Contributor

If you'd feel more comfortable with a .to_s, though, I'm happy to add it.

@jessepinho

jessepinho Jan 2, 2015

Contributor

If you'd feel more comfortable with a .to_s, though, I'm happy to add it.

@parkr parkr merged commit d8e5173 into jekyll:master Jan 2, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jan 2, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.