New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla importer #188

Merged
merged 6 commits into from Nov 3, 2015

Conversation

Projects
None yet
3 participants
@va7sdf
Contributor

va7sdf commented Mar 7, 2015

  1. The importer was generating pages for articles outside the selected category. Added parentheses so the proper precedence is enforced.
  2. Joomla! article aliases are used to construct the filename as YYYY-MM-DD-alias.markdown. Some aliases in the database I was importing were blank resulting in YYYY-MM-DD-.markdown filenames. If more than one article was missing the alias and happened to be authored on the same day, each would overwrite the previous only leaving the last imported. Using the title, when the alias was empty, resolved these conflicts.
  3. Some aliases / titles contained characters that were illegal for filenames and the importer would terminate with an error when attempting to write the file. Borrowed the sluggify method from the Wordpress importer to strip all illegal characters from the filename.

Note: I actually imported from Joomla 1.0.15. The only difference is the field name "alias" in 1.5 is "title_alias" in 1.0.15. I simply renamed the field (in an offline copy of the database) and the importer worked.

@va7sdf va7sdf changed the title from Va7sdf patch 1 to Joomla importer Mar 18, 2015

parkr added a commit that referenced this pull request Nov 3, 2015

@parkr parkr merged commit a555edc into jekyll:master Nov 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Nov 3, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.