New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the old mysql driver results in broken YAML frontmatters #20

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@x3ro
Contributor

x3ro commented Mar 31, 2013

When using the old mysql driver, the returned string data always
seems to have a ASCII-8BIT encoding. to_yaml however expects all
strings to be UTF-8, and if they are not, encodes them as if they were
binary, which in turn breaks the Jekyll site generation (breaks in the
sense that category names are all garbled, for example)

Reference for the mysql driver behaviour:
http://stackoverflow.com/q/14070281/124257

Using the old mysql driver results in broken YAML frontmatters
When using the old mysql driver, the returned string data always
seems to have a ASCII-8BIT encoding. `to_yaml` however expects all
strings to be UTF-8, and if they are not encodes them as they were
binary, which in turn breaks the Jekyll site generation (breaks in the
sense that category names are all garbled, for example)

Reference for the mysql driver behaviour:
http://stackoverflow.com/q/14070281/124257
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 1, 2013

Member

Weird test failure due to 1.8.7 can't find psych.

Member

parkr commented Apr 1, 2013

Weird test failure due to 1.8.7 can't find psych.

@x3ro

This comment has been minimized.

Show comment
Hide comment
@x3ro

x3ro Apr 1, 2013

Contributor

Seems to be happening in #15 too, though. I'm fairly certain that I didn't cause the issue. I'll install a 1.8.7 to see if I can reproduce it though.

Contributor

x3ro commented Apr 1, 2013

Seems to be happening in #15 too, though. I'm fairly certain that I didn't cause the issue. I'll install a 1.8.7 to see if I can reproduce it though.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 2, 2013

Member

Thank you!!!

Member

parkr commented Apr 2, 2013

Thank you!!!

@parkr parkr closed this in 4d3aac8 May 6, 2013

parkr added a commit that referenced this pull request May 6, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.