New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post-merge hiccups after #213 #218

Merged
merged 2 commits into from Sep 13, 2015

Conversation

Projects
None yet
3 participants
@danbernier
Contributor

danbernier commented Sep 5, 2015

It looks like there were some hiccups with the cleanup after merging #213:

  • Some local variables were removed. This replaces their reference sites with calls to the appropriate Item methods.
  • It was trying to call .empty? on an Hpricot::Doc, which doesn't support that method.
    • This also stops including empty excerpts in a Post's metadata.

danbernier added some commits Aug 17, 2015

Extract Item#excerpt for handling post excerpts.
This fixes two problems:

1. It checks `.empty?` on a String, not a Hpricot::Doc (which doesn't
have that method)
2. It returns nil if the excerpt is empty, so it won't record an
empty-string excerpt.

@danbernier danbernier changed the title from Fix orphaned local variables: use the methods on Item class. to Fix post-merge hiccups after #213 Sep 5, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 13, 2015

Member

Thanks!

Member

parkr commented Sep 13, 2015

Thanks!

parkr added a commit that referenced this pull request Sep 13, 2015

@parkr parkr merged commit cfa3d22 into jekyll:master Sep 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Sep 13, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.