New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tumblr: Update range of JSON readlines to extract JSON from JS (Tumblr may have changed structure of JSON) #243

Merged
merged 1 commit into from Apr 27, 2016

Conversation

Projects
None yet
3 participants
@karenjho
Contributor

karenjho commented Mar 29, 2016

Tumblr might have changed the structure of its JSON recently. The jekyll Tumblr importer is currently stripping out the ending curly brace (results in an "unexpected token error" with JSON parser).

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 14, 2016

Member

Thanks for the PR, @karenjho! What do you think about searching the string for the index of the first {, then finding the last }? Maybe not ideal, but a thought?

Member

parkr commented Apr 14, 2016

Thanks for the PR, @karenjho! What do you think about searching the string for the index of the first {, then finding the last }? Maybe not ideal, but a thought?

@parkr parkr changed the title from Update range of JSON readlines (Tumblr may have changed structure of JSON) to Tumblr: Update range of JSON readlines to extract JSON from JS (Tumblr may have changed structure of JSON) Apr 27, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 27, 2016

Member

@jekyllbot: merge +bug

Member

parkr commented Apr 27, 2016

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit bc03d65 into jekyll:master Apr 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Apr 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment