Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
joomla: use & require mysql2 instead of mysql #255
joomla.rb was using Sequel.mysql, which appears to depend on the gem mysql. This is depracated and replacing mysql with mysql2 works fine; it is already in use for wordpress.rb. I also added the requirement for the mysql2 gem, as this doesn't appear to work without that.
Details of my error message when running the vanilla joomla importer without mysql:
I suggest, furthermore, that we say MySQL (not the gem) needs to be installed, which is not obvious to people who rent their webserver and database from a third party (i.e., me! heh). I'm not sure how to edit the documentation for joomla.rb, but it definitely needs to go onto individual importer pages, since a user of X CMS will not be looking over the documentation for Y CMS necessarily.
This is my first ever pull request so any comments on how I've done it are welcome.
Jul 14, 2016
1 check passed
added a commit
this pull request
Jul 14, 2016
Looks like the same needs to be done for the Joomla3 converter. I had to recently do some imports and had to manually apply the changes. Is there a specific reason for this not being updated or should I proceed with a PR?
Also I think it's worth adding a