New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tumblr: close conversation HTML tags in the right order #266

Merged
merged 1 commit into from Jul 19, 2016

Conversation

Projects
None yet
3 participants
@thachhoang
Contributor

thachhoang commented Jul 19, 2016

No description provided.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 19, 2016

Member

Hey @thachhoang! Is this a recent change or has it been wrong all along?

Member

parkr commented Jul 19, 2016

Hey @thachhoang! Is this a recent change or has it been wrong all along?

@thachhoang

This comment has been minimized.

Show comment
Hide comment
@thachhoang

thachhoang Jul 19, 2016

Contributor

This has been around since 2013 at least.

content << "</section></dialog>"

Contributor

thachhoang commented Jul 19, 2016

This has been around since 2013 at least.

content << "</section></dialog>"

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 19, 2016

Member

@thachhoang Ouch! Thanks for this.

Member

parkr commented Jul 19, 2016

@thachhoang Ouch! Thanks for this.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 19, 2016

Member

LGTM.

Member

parkr commented Jul 19, 2016

LGTM.

@parkr parkr changed the title from Close Tumblr conversation HTML tags in the right order to Tumblr: close conversation HTML tags in the right order Jul 19, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 19, 2016

Member

@jekyllbot: merge

Member

parkr commented Jul 19, 2016

@jekyllbot: merge

@jekyllbot jekyllbot merged commit 94e8bd0 into jekyll:master Jul 19, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jekyll/lgtm Approved by @parkr.

jekyllbot added a commit that referenced this pull request Jul 19, 2016

@parkr parkr added the fix label Jul 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment