New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrupalCommon: centralize defaults & use config for layouts dir #267

Merged
merged 2 commits into from Jul 20, 2016

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Jul 19, 2016

@borfast, would you mind taking a 馃憖 at this? Addresses 2 of my comments. 馃槃

/cc #235

parkr added some commits Jul 19, 2016

@parkr parkr changed the title from Apply updates to to Apply updates to DrupalCommon Jul 19, 2016

@parkr parkr changed the title from Apply updates to DrupalCommon to DrupalCommon: centralize defaults & use config for layouts dir Jul 19, 2016

@borfast

This comment has been minimized.

Show comment
Hide comment
@borfast

borfast Jul 19, 2016

Contributor

Looks good.

One question: is there a reason not to allow customising the _posts and _drafts directories like _layouts?

Contributor

borfast commented Jul 19, 2016

Looks good.

One question: is there a reason not to allow customising the _posts and _drafts directories like _layouts?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 20, 2016

Member

Sweet, thanks!

One question: is there a reason not to allow customising the _posts and _drafts directories like _layouts?

Yeah. "Posts" is a collection and follows the convention of _#{collection_label}. I suppose we could allow reconfiguration of the drafts location in theory, but it came about right when we started pushing for more Convention over Configuration.

too many knobs

Member

parkr commented Jul 20, 2016

Sweet, thanks!

One question: is there a reason not to allow customising the _posts and _drafts directories like _layouts?

Yeah. "Posts" is a collection and follows the convention of _#{collection_label}. I suppose we could allow reconfiguration of the drafts location in theory, but it came about right when we started pushing for more Convention over Configuration.

too many knobs

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 20, 2016

Member

LGTM.

Member

parkr commented Jul 20, 2016

LGTM.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 20, 2016

Member

@jekyllbot: merge

Member

parkr commented Jul 20, 2016

@jekyllbot: merge

@jekyllbot jekyllbot merged commit 704b6b4 into master Jul 20, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jekyll/lgtm Approved by @parkr.

@jekyllbot jekyllbot deleted the borfast-generic-drupal branch Jul 20, 2016

jekyllbot added a commit that referenced this pull request Jul 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment