New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for misnamed Joomla3 module in docs #271

Merged
merged 2 commits into from Sep 18, 2016

Conversation

Projects
None yet
4 participants
@GreatEmerald
Contributor

GreatEmerald commented Aug 16, 2016

Fixes issue #270

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Aug 16, 2016

Member

Looks like we need to drop Ruby 1.9 from the test suite.

Member

pathawks commented Aug 16, 2016

Looks like we need to drop Ruby 1.9 from the test suite.

Category is in fact a number (ID)
Made it more clear what the category is supposed to be about, as it looked like a string while it really is not.
If one was to put the number between quotes, one would get "comparison of String with 0 failed (ArgumentError)"
@GreatEmerald

This comment has been minimized.

Show comment
Hide comment
@GreatEmerald

GreatEmerald Aug 17, 2016

Contributor

Added another small improvement: the category field is numerical, not a string.

Contributor

GreatEmerald commented Aug 17, 2016

Added another small improvement: the category field is numerical, not a string.

"prefix" => "mytableprefix"
})'
{% endhighlight %}
The only required fields are `dbname`, `prefix` and `user`. `password` defaults to `""`,
and `host` defaults to `"localhost"`.
If the `category` field is not filled, all articles will be imported, except the ones that are
If the `category` numerical field is not filled, all articles will be imported, except the ones that are

This comment has been minimized.

@parkr

parkr Aug 29, 2016

Member

Is the category always numerical?

@parkr

parkr Aug 29, 2016

Member

Is the category always numerical?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 29, 2016

Member

Thanks! One question above.

Member

parkr commented Aug 29, 2016

Thanks! One question above.

@GreatEmerald

This comment has been minimized.

Show comment
Hide comment
@GreatEmerald

GreatEmerald Aug 29, 2016

Contributor

In the current implementation of the importer, yes. Joomla stores categories as numbers; there is also a table that maps those numbers into human-readable names. It would be nice to make use of that, but it would make the tool quite a bit more complex.

Contributor

GreatEmerald commented Aug 29, 2016

In the current implementation of the importer, yes. Joomla stores categories as numbers; there is also a table that maps those numbers into human-readable names. It would be nice to make use of that, but it would make the tool quite a bit more complex.

@parkr

parkr approved these changes Sep 18, 2016

Category as integer value sounds good to me, thank you!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 18, 2016

Member

@jekyllbot: merge +site

Member

parkr commented Sep 18, 2016

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 7a2060a into jekyll:master Sep 18, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
jekyll/lgtm Awaiting approval from at least 1 maintainer.

jekyllbot added a commit that referenced this pull request Sep 18, 2016

@GreatEmerald GreatEmerald deleted the GreatEmerald:patch-1 branch Sep 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment