New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blogger: replace special characters with hyphens in the post name #280

Merged
merged 3 commits into from Nov 6, 2017

Conversation

Projects
None yet
3 participants
@soywiz
Contributor

soywiz commented Oct 18, 2016

No description provided.

@soywiz

This comment has been minimized.

Show comment
Hide comment
@soywiz

soywiz Oct 18, 2016

Contributor

Tried (with bash-for-windows and plain windows), but failed miserably, into setting up the test environment. So no tests here. I could try on my macbook but no guarantees. Also I don't know ruby.
Another option:
I could try to add a test that just places a xml with the title with special characters (using other test as reference), and do not place any assert at all. But at least checks that there are no exceptions. If I remember fine, it throws an exception with a wrong file name. And let travis tell me if that was fine directly in the PR :P

Contributor

soywiz commented Oct 18, 2016

Tried (with bash-for-windows and plain windows), but failed miserably, into setting up the test environment. So no tests here. I could try on my macbook but no guarantees. Also I don't know ruby.
Another option:
I could try to add a test that just places a xml with the title with special characters (using other test as reference), and do not place any assert at all. But at least checks that there are no exceptions. If I remember fine, it throws an exception with a wrong file name. And let travis tell me if that was fine directly in the PR :P

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 18, 2016

Member

Fixes #277.

Member

parkr commented Oct 18, 2016

Fixes #277.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 17, 2016

Member

@soywiz Do you still want to apply the changes that I asked for above?

Member

parkr commented Dec 17, 2016

@soywiz Do you still want to apply the changes that I asked for above?

parkr added some commits Nov 6, 2017

@parkr

parkr approved these changes Nov 6, 2017

@parkr parkr changed the title from Blogger importer problem with special characters in title Fixes #277 to Blogger: replace special characters with hyphens in the post name Nov 6, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 6, 2017

Member

Thank you!

@jekyllbot: merge +bug

Member

parkr commented Nov 6, 2017

Thank you!

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 8512897 into jekyll:master Nov 6, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jekyllbot jekyllbot added bug fix labels Nov 6, 2017

jekyllbot added a commit that referenced this pull request Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment