New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Ruby and Jekyll versions for testing #290

Merged
merged 5 commits into from Jan 17, 2017

Conversation

Projects
None yet
4 participants
@njt1982
Contributor

njt1982 commented Jan 15, 2017

Nokogiri no longer supports Ruby 1.9.3 it seems, causing tests to fail.

Given 1.9.3 is EOL, IMHO it should not longer be supported by this Gem.

Also, 2.0 is EOL so there is no point adding that. And it seems 2.3 and 2.4 are not available yet either.

njt1982 added some commits Jan 15, 2017

Updating Ruby and Jekyll versions for testing
Nokogiri no longer supports Ruby 1.9.3 it seems, causing tests to fail.
Show outdated Hide outdated .travis.yml
Show outdated Hide outdated .travis.yml
Show outdated Hide outdated .travis.yml
Show outdated Hide outdated .travis.yml
3.0 and 3.3 both resolve to the same release
2.5 will also resolve to 2.5.3 too.
@pathawks

LGTM. Thanks @njt1982 👍

@njt1982

This comment has been minimized.

Show comment
Hide comment
@njt1982

njt1982 Jan 16, 2017

Contributor

@pathawks thanks for the quick reviews - would be good to get this in so other PR's can be properly tested :)

Contributor

njt1982 commented Jan 16, 2017

@pathawks thanks for the quick reviews - would be good to get this in so other PR's can be properly tested :)

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 17, 2017

Member

@jekyllbot: merge +dev

Member

parkr commented Jan 17, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 5e33eb8 into jekyll:master Jan 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jan 17, 2017

@njt1982 njt1982 deleted the njt1982:patch-3 branch Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment