New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mysql2 instead of mysql in Joomla3 importer #309

Merged
merged 3 commits into from May 29, 2017

Conversation

Projects
None yet
3 participants
@ienev
Contributor

ienev commented May 24, 2017

Use and require mysql2 gem instead of mysql for the Joomla3 importer. Change similar to the one for the Joomla importer - #255.

@ienev

This comment has been minimized.

Show comment
Hide comment
@ienev

ienev May 24, 2017

Contributor

AFAIK the mysql gem won't compile with ruby 2.4 due to the Fixnum and Bignum unification:

compiling mysql.c
mysql.c: In function ‘stmt_bind_result’:
mysql.c:1320:74: error: ‘rb_cFixnum’ undeclared (first use in this function)
  else if (argv[i] == rb_cNumeric || argv[i] == rb_cInteger || argv[i] == rb_cFixnum)
                                                                          ^
mysql.c:1320:74: note: each undeclared identifier is reported only once for each function it appears in
mysql.c: At top level:
cc1: warning: unrecognized command line option ‘-Wno-self-assign’
cc1: warning: unrecognized command line option ‘-Wno-constant-logical-operand’
cc1: warning: unrecognized command line option ‘-Wno-parentheses-equality’
cc1: warning: unrecognized command line option ‘-Wno-tautological-compare’
Makefile:241: recipe for target 'mysql.o' failed
make: *** [mysql.o] Error 1

make failed, exit code 2

The maintainer has deprecated development of the gem and no new version has been released for the past 4 years.

Since there are other importers using mysql, may be it is worth applying this change to them too? The gem is also required as a development dependency in the gemspec. This seems like a something that needs to be discussed though (probably in a separate Issue) as it only affects ruby 2.4.

Contributor

ienev commented May 24, 2017

AFAIK the mysql gem won't compile with ruby 2.4 due to the Fixnum and Bignum unification:

compiling mysql.c
mysql.c: In function ‘stmt_bind_result’:
mysql.c:1320:74: error: ‘rb_cFixnum’ undeclared (first use in this function)
  else if (argv[i] == rb_cNumeric || argv[i] == rb_cInteger || argv[i] == rb_cFixnum)
                                                                          ^
mysql.c:1320:74: note: each undeclared identifier is reported only once for each function it appears in
mysql.c: At top level:
cc1: warning: unrecognized command line option ‘-Wno-self-assign’
cc1: warning: unrecognized command line option ‘-Wno-constant-logical-operand’
cc1: warning: unrecognized command line option ‘-Wno-parentheses-equality’
cc1: warning: unrecognized command line option ‘-Wno-tautological-compare’
Makefile:241: recipe for target 'mysql.o' failed
make: *** [mysql.o] Error 1

make failed, exit code 2

The maintainer has deprecated development of the gem and no new version has been released for the past 4 years.

Since there are other importers using mysql, may be it is worth applying this change to them too? The gem is also required as a development dependency in the gemspec. This seems like a something that needs to be discussed though (probably in a separate Issue) as it only affects ruby 2.4.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 24, 2017

Member

may be it is worth applying this change to them too?

That sounds great! Want to upgrade all of them in this PR? 😍

Member

parkr commented May 24, 2017

may be it is worth applying this change to them too?

That sounds great! Want to upgrade all of them in this PR? 😍

@ienev

This comment has been minimized.

Show comment
Hide comment
@ienev

ienev May 24, 2017

Contributor

Want to upgrade all of them in this PR?

Sure. What about the .gemspec? I guess requiring mysql won't be needed anymore?

Contributor

ienev commented May 24, 2017

Want to upgrade all of them in this PR?

Sure. What about the .gemspec? I guess requiring mysql won't be needed anymore?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 24, 2017

Member

Sure. What about the .gemspec? I guess requiring mysql won't be needed anymore?

Yes! You can replace that with mysql2 or just remove it.

Member

parkr commented May 24, 2017

Sure. What about the .gemspec? I guess requiring mysql won't be needed anymore?

Yes! You can replace that with mysql2 or just remove it.

ienev added some commits May 24, 2017

joomla3-importer-use-mysql2
* Use and require mysql2 instead of mysql in all importers
* Explicitly require sqlite3 and pg in importers that use them
@parkr

parkr approved these changes May 29, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 29, 2017

Member

@jekyllbot: merge

Member

parkr commented May 29, 2017

@jekyllbot: merge

@jekyllbot jekyllbot merged commit 8a40285 into jekyll:master May 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request May 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment