New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify the MySQL port for the Joomla importers #310

Merged
merged 2 commits into from Jun 20, 2017

Conversation

Projects
None yet
3 participants
@ienev
Contributor

ienev commented May 24, 2017

  • Add option to specify the MySQL port for the Joomla importers
  • Use Ruby 1.9 hash syntax
  • Update the Joomla importers documentation
@ienev

This comment has been minimized.

Show comment
Hide comment
@ienev

ienev May 29, 2017

Contributor

@parkr I'll fix the conflicts, but are you OK with this PR?

Contributor

ienev commented May 29, 2017

@parkr I'll fix the conflicts, but are you OK with this PR?

add-port-option-for-joomla-importers
* Add option to specify the MySQL port for the Joomla importers
* Use Ruby 1.9 hash syntax
* Update the Joomla importers documentation
@ienev

This comment has been minimized.

Show comment
Hide comment
@ienev

ienev Jun 2, 2017

Contributor

Conflicts solved.

Contributor

ienev commented Jun 2, 2017

Conflicts solved.

@pathawks pathawks requested a review from parkr Jun 2, 2017

@ienev

This comment has been minimized.

Show comment
Hide comment
@ienev

ienev Jun 4, 2017

Contributor

One of the build jobs seems stuck. Is this normal, should I just wait or there is a way to restart the jobs?

Contributor

ienev commented Jun 4, 2017

One of the build jobs seems stuck. Is this normal, should I just wait or there is a way to restart the jobs?

@parkr

parkr approved these changes Jun 20, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 20, 2017

Member

No, that's not normal! I tried to restart it but it didn't work. Weird! Merging anyway.

@jekyllbot: merge

Member

parkr commented Jun 20, 2017

No, that's not normal! I tried to restart it but it didn't work. Weird! Merging anyway.

@jekyllbot: merge

@jekyllbot jekyllbot merged commit 142f1b5 into jekyll:master Jun 20, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

jekyllbot added a commit that referenced this pull request Jun 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment