New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add port options for wordpress mysql db connection #311

Merged
merged 1 commit into from Jun 27, 2017

Conversation

Projects
None yet
4 participants
@passos
Contributor

passos commented Jun 22, 2017

No description provided.

@mattr-

mattr- approved these changes Jun 27, 2017

LGTM. Thanks! ❤️

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-
Member

mattr- commented Jun 27, 2017

@jekyllbot: merge

@jekyllbot jekyllbot merged commit 73f5b63 into jekyll:master Jun 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jun 27, 2017

@@ -77,6 +79,7 @@ def self.process(opts)
:user => opts.fetch('user', ''),
:pass => opts.fetch('password', ''),
:host => opts.fetch('host', 'localhost'),
:port => opts.fetch('port', '3306'),

This comment has been minimized.

@parkr

parkr Jun 27, 2017

Member

Should this be a string 3306, or an integer 3306?

@parkr

parkr Jun 27, 2017

Member

Should this be a string 3306, or an integer 3306?

This comment has been minimized.

@mattr-

mattr- Jun 27, 2017

Member

The mysql2 gem will handle both an integer and a string so it doesn't matter.

@mattr-

mattr- Jun 27, 2017

Member

The mysql2 gem will handle both an integer and a string so it doesn't matter.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 27, 2017

Member

The documentation also needs to be updated.

Member

parkr commented Jun 27, 2017

The documentation also needs to be updated.

mattr- added a commit that referenced this pull request Jun 28, 2017

Add the new port setting to the Wordpress importer docs
Missed this before when reviewing and merging #311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment