New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Drupal 7 migrations #38

Merged
merged 1 commit into from Jul 8, 2013

Conversation

Projects
None yet
4 participants
@erikwebb
Contributor

erikwebb commented Jul 5, 2013

The SQL command in the Drupal 7 migration script does not work as expected. n.vid refers to the revision of a node, while fdb.entity_id refers to the id of the node itself. Instead fdb.entity_id should be compared to n.nid. I've added another constraint to only use the current revision of each node.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 5, 2013

Member

Thank you for the PR! This is awesome, and LGTM. @mattr-?

Member

parkr commented Jul 5, 2013

Thank you for the PR! This is awesome, and LGTM. @mattr-?

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jul 8, 2013

Member

👍 :shipit:

Member

mattr- commented Jul 8, 2013

👍 :shipit:

parkr added a commit that referenced this pull request Jul 8, 2013

@parkr parkr merged commit 082b689 into jekyll:master Jul 8, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jul 8, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.