New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial version of a test case for Tumblr #43

Merged
merged 1 commit into from Jul 25, 2013

Conversation

Projects
None yet
4 participants
@georgeanderson
Contributor

georgeanderson commented Jul 24, 2013

I found tumblr.rb not an easy module to test. I have started with the most simple data check from a mocked JSON payload and was able to cover the basics of JekyllImport::Tumblr.post_to_hash. I can go just a little bit further without refactoring the module, so I thought I should start a pull request to gather feedbacks.

Oh, and I had to bump rake version up because I was hitting the issue mentioned here.

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jul 24, 2013

Member

🆒 This is a great start!

@parkr what do you think?

Member

mattr- commented Jul 24, 2013

🆒 This is a great start!

@parkr what do you think?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 24, 2013

Member

LGTM! How about we merge and refactor in a different PR?

Member

parkr commented Jul 24, 2013

LGTM! How about we merge and refactor in a different PR?

@georgeanderson

This comment has been minimized.

Show comment
Hide comment
@georgeanderson

georgeanderson Jul 25, 2013

Contributor

Sounds good to me guys. I will keep working on this branch and will open new PRs.

Contributor

georgeanderson commented Jul 25, 2013

Sounds good to me guys. I will keep working on this branch and will open new PRs.

parkr added a commit that referenced this pull request Jul 25, 2013

Merge pull request #43 from georgeanderson/tumblr_test
Added initial version of a test case for Tumblr

@parkr parkr merged commit 88f7b08 into jekyll:master Jul 25, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jul 26, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.