For MT: :entry_text_more attribute is nil or not before evaluate

[shigeya]

This happen when I tried my MovableType blog import (still on going)

[parkr]

Oh great, thanks!

LGTM. @mattr-?

[mattr-]

for a quick fix, this is fine. If you wanted to take this a step further, you could wrap the conditional in a method to improve the clarity of the code.

def extra_entry_text_empty?(post)
  post[:entry_text_more].nil? || post[:entry_text_more].strip.empty?
end

and replace the condition like so:

if extra_entry_text_empty?(post)
...
end

[shigeya]

I like that modification better, but only if you want to cost lines+methods for clarity. (besides the commit message's clarity). will change and push again later.

[shigeya]

Updated.

[mattr-]

I will always take clearer code over code that is less lines. Thanks for updating this! 😃

[shigeya]

no problem. Looks like travis said OK.

[parkr]

Boom! LGTM.

[shigeya]

tnx