Include page number in title - #250
Merged
Merged
Conversation
Member
|
/cc: @jekyll/ecosystem |
DirtyF
approved these changes
Mar 8, 2018
DirtyF
left a comment
DirtyF
left a comment
Member
There was a problem hiding this comment.
Fine by me. Thanks @mpchadwick
benbalter
approved these changes
Mar 8, 2018
| end | ||
|
|
||
| def page_number | ||
| return if !@context["paginator"] || !@context["paginator"]["page"] |
Collaborator
There was a problem hiding this comment.
I'd write this as return unless @context["paginator"] && @context["paginator"]["page"] to make the intent a bit more clear.
Member
|
@jekyllbot: merge +minor |
Member
|
Thanks @mpchadwick 😃 |
pathawks
reviewed
Mar 8, 2018
|
|
||
| if page_number | ||
| return page_number + @title | ||
| end |
Member
There was a problem hiding this comment.
Is it intentional that we are not memoizing this?
|
Is there a way to disable this feature? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Moz's article "Pagination: Best Practices for SEO & User Experience" it's not ideal to use the same title with pagination. This change follows Moz's suggestion and appends "Page X of Y for" to the beginning of the
<title>when on page 2 of deeper.