Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upInclude page number in title #250
Conversation
This comment has been minimized.
This comment has been minimized.
|
/cc: @jekyll/ecosystem |
DirtyF
requested a review
from jekyll/plugin-core
Mar 8, 2018
lib/jekyll-seo-tag/drop.rb
Outdated
| @@ -175,6 +181,17 @@ def homepage_or_about? | |||
| page["url"] =~ HOMEPAGE_OR_ABOUT_REGEX | |||
| end | |||
|
|
|||
| def page_number | |||
| return if !@context["paginator"] || !@context["paginator"]["page"] | |||
This comment has been minimized.
This comment has been minimized.
benbalter
Mar 8, 2018
Collaborator
I'd write this as return unless @context["paginator"] && @context["paginator"]["page"] to make the intent a bit more clear.
DirtyF
added some commits
Mar 8, 2018
This comment has been minimized.
This comment has been minimized.
|
@jekyllbot: merge +minor |
jekyllbot
merged commit ead4375
into
jekyll:master
Mar 8, 2018
jekyllbot
added
the
enhancement
label
Mar 8, 2018
added a commit
that referenced
this pull request
Mar 8, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks @mpchadwick |
|
|
||
| if page_number | ||
| return page_number + @title | ||
| end |
This comment has been minimized.
This comment has been minimized.
benbalter
referenced this pull request
May 23, 2018
Closed
Duplicate meta descriptions with pagination #265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mpchadwick commentedNov 17, 2017
•
edited
Per Moz's article "Pagination: Best Practices for SEO & User Experience" it's not ideal to use the same title with pagination. This change follows Moz's suggestion and appends "Page X of Y for" to the beginning of the
<title>when on page 2 of deeper.