Include page number in title #250
Merged
Conversation
|
/cc: @jekyll/ecosystem |
|
Fine by me. Thanks @mpchadwick |
lib/jekyll-seo-tag/drop.rb
Outdated
| @@ -175,6 +181,17 @@ def homepage_or_about? | |||
| page["url"] =~ HOMEPAGE_OR_ABOUT_REGEX | |||
| end | |||
|
|
|||
| def page_number | |||
| return if !@context["paginator"] || !@context["paginator"]["page"] | |||
benbalter
Mar 8, 2018
Collaborator
I'd write this as return unless @context["paginator"] && @context["paginator"]["page"] to make the intent a bit more clear.
I'd write this as return unless @context["paginator"] && @context["paginator"]["page"] to make the intent a bit more clear.
|
@jekyllbot: merge +minor |
jekyllbot
added a commit
that referenced
this pull request
Mar 8, 2018
|
Thanks @mpchadwick |
|
|
||
| if page_number | ||
| return page_number + @title | ||
| end |
pathawks
Mar 8, 2018
Member
Is it intentional that we are not memoizing this?
Is it intentional that we are not memoizing this?
|
Is there a way to disable this feature? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Per Moz's article "Pagination: Best Practices for SEO & User Experience" it's not ideal to use the same title with pagination. This change follows Moz's suggestion and appends "Page X of Y for" to the beginning of the
<title>when on page 2 of deeper.