From 82bb2714df846b9126b1ad9b9a447cb3dc733bee Mon Sep 17 00:00:00 2001 From: Ashwin Maroli Date: Sun, 18 Dec 2022 18:44:02 +0530 Subject: [PATCH] Remove totals in profile table properly (#9186) Merge pull request 9186 --- lib/jekyll/liquid_renderer/table.rb | 12 +----------- lib/jekyll/profiler.rb | 4 ---- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/lib/jekyll/liquid_renderer/table.rb b/lib/jekyll/liquid_renderer/table.rb index b354b15d379..2d06a26a76a 100644 --- a/lib/jekyll/liquid_renderer/table.rb +++ b/lib/jekyll/liquid_renderer/table.rb @@ -15,16 +15,12 @@ def to_s(num_of_rows = 50) private - # rubocop:disable Metrics/AbcSize def data_for_table(num_of_rows) sorted = @stats.sort_by { |_, file_stats| -file_stats[:time] } sorted = sorted.slice(0, num_of_rows) table = [header_labels] - totals = Hash.new { |hash, key| hash[key] = 0 } - sorted.each do |filename, file_stats| - GAUGES.each { |gauge| totals[gauge] += file_stats[gauge] } row = [] row << filename row << file_stats[:count].to_s @@ -33,14 +29,8 @@ def data_for_table(num_of_rows) table << row end - footer = [] - footer << "TOTAL (for #{sorted.size} files)" - footer << totals[:count].to_s - footer << format_bytes(totals[:bytes]) - footer << format("%.3f", totals[:time]) - table << footer + table end - # rubocop:enable Metrics/AbcSize def header_labels GAUGES.map { |gauge| gauge.to_s.capitalize }.unshift("Filename") diff --git a/lib/jekyll/profiler.rb b/lib/jekyll/profiler.rb index 9dd879f1d38..f5dbfb18e7e 100644 --- a/lib/jekyll/profiler.rb +++ b/lib/jekyll/profiler.rb @@ -33,18 +33,14 @@ def initialize(site) def profile_process profile_data = { "PHASE" => "TIME" } - total_time = 0 [:reset, :read, :generate, :render, :cleanup, :write].each do |method| start_time = Time.now @site.send(method) end_time = (Time.now - start_time).round(4) profile_data[method.to_s.upcase] = format("%.4f", end_time) - total_time += end_time end - profile_data["TOTAL TIME"] = format("%.4f", total_time) - Jekyll.logger.info "\nBuild Process Summary:" Jekyll.logger.info Profiler.tabulate(Array(profile_data))