New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`jekyll` command prints a backtrace #1040

Closed
postmodern opened this Issue May 7, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@postmodern
Contributor

postmodern commented May 7, 2013

Users should never see a backtrace from a CLI program.

$ jekyll
       Deprecation: Jekyll now uses subcommands instead of just switches. Run `jekyll help' to find out more.
/home/hal/.gem/ruby/1.9.1/gems/commander-4.1.3/lib/commander/runner.rb:365:in `block in require_program': program version required (Commander::Runner::CommandError)
    from /home/hal/.gem/ruby/1.9.1/gems/commander-4.1.3/lib/commander/runner.rb:364:in `each'
    from /home/hal/.gem/ruby/1.9.1/gems/commander-4.1.3/lib/commander/runner.rb:364:in `require_program'
    from /home/hal/.gem/ruby/1.9.1/gems/commander-4.1.3/lib/commander/runner.rb:52:in `run!'
    from /home/hal/.gem/ruby/1.9.1/gems/commander-4.1.3/lib/commander/delegates.rb:11:in `run!'
    from /home/hal/.gem/ruby/1.9.1/gems/commander-4.1.3/lib/commander/import.rb:10:in `block in '
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 7, 2013

Member

Users should never see a backtrace from a CLI program.

I hope you're kidding! Backtraces are incredibly helpful.

I agree that this could be cleaner, though.

Member

parkr commented May 7, 2013

Users should never see a backtrace from a CLI program.

I hope you're kidding! Backtraces are incredibly helpful.

I agree that this could be cleaner, though.

@postmodern

This comment has been minimized.

Show comment
Hide comment
@postmodern

postmodern May 7, 2013

Contributor

@parkr I am not kidding. Print a proper error message. Backtraces are only useful to developers, not users.

Contributor

postmodern commented May 7, 2013

@parkr I am not kidding. Print a proper error message. Backtraces are only useful to developers, not users.

@parkr

This comment has been minimized.

Show comment
Hide comment

@parkr parkr closed this in d0a9948 May 7, 2013

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 7, 2013

Member

Now prints this:

~/code/jekyll/site$ bundle exec ../bin/jekyll --server
       Deprecation: Jekyll now uses subcommands instead of just switches. Run `jekyll help' to find out more.
       Deprecation: The --server command has been replaced by the 'serve' subcommand.
invalid option: --server
Member

parkr commented May 7, 2013

Now prints this:

~/code/jekyll/site$ bundle exec ../bin/jekyll --server
       Deprecation: Jekyll now uses subcommands instead of just switches. Run `jekyll help' to find out more.
       Deprecation: The --server command has been replaced by the 'serve' subcommand.
invalid option: --server

parkr added a commit that referenced this issue May 7, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.