paginator page_path attributes ignore paginate_path in _config.yml #1197

Closed
heuristicus opened this Issue Jun 9, 2013 · 3 comments

Comments

Projects
None yet
4 participants
@heuristicus

When paginate_path is defined in _config.yml, using the paginator.next_page_path variable does not return the path expected.

For example, if you have paginate_path: /blog/page:num defined in the config file, the value of the next_page_path variable on page N is pageN+1, rather than the expected/blog/pageN+1. previous_page_path has a similar issue, just with N-1 rather than N+1.

@parkr

This comment has been minimized.

Show comment Hide comment
@parkr

parkr Jun 9, 2013

Member

I've actually fixed that up for the most part. The paginator used to use the Pager.pagination_path just to get the relative path (we used to not allow it in subdirectories, so it's an oversight from the expansion to subdirectories) and we'd put it in the proper dir later. I am just fixing up the tests, then I'll submit a PR and have it ready for the v1.1 release.

Member

parkr commented Jun 9, 2013

I've actually fixed that up for the most part. The paginator used to use the Pager.pagination_path just to get the relative path (we used to not allow it in subdirectories, so it's an oversight from the expansion to subdirectories) and we'd put it in the proper dir later. I am just fixing up the tests, then I'll submit a PR and have it ready for the v1.1 release.

@fabianrbz

This comment has been minimized.

Show comment Hide comment
@fabianrbz

fabianrbz Apr 5, 2014

Member

is this still an issue? I wasn't able to reproduce it with the latest version. 😃

Member

fabianrbz commented Apr 5, 2014

is this still an issue? I wasn't able to reproduce it with the latest version. 😃

@parkr

This comment has been minimized.

Show comment Hide comment
@parkr

parkr Apr 6, 2014

Member

Shouldn't be! Thanks @fabianrbz :)

Member

parkr commented Apr 6, 2014

Shouldn't be! Thanks @fabianrbz :)

@parkr parkr closed this Apr 6, 2014

@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.