Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rdiscount extensions #173

Closed
ctrochalakis opened this Issue Jun 2, 2010 · 7 comments

Comments

Projects
None yet
4 participants
@ctrochalakis
Copy link
Contributor

ctrochalakis commented Jun 2, 2010

Hello, I have created a patch adding support for rdiscount extensions.

For example now you can do something like this:

rdiscount:
    extensions: [smart, autolink]

The actual code is here (rdiscount-extensions branch): ctrochalakis/jekyll@b96516a6de41a04076960ad735e2d4650bf34d47

@mojombo

This comment has been minimized.

Copy link
Contributor

mojombo commented Jun 19, 2010

This looks good. Can you rebase this on top of the latest master? Converters have been changed to be plugins and this patch will need to adjust for that.

@ctrochalakis

This comment has been minimized.

Copy link
Contributor Author

ctrochalakis commented Jun 21, 2010

@mojombo

This comment has been minimized.

Copy link
Contributor

mojombo commented Jun 22, 2010

Three more things and I can merge this in: 1) Change the &:to_sym to the pre 1.8.7 syntax to make sure this works for older Rubys. 2) Include a test that exercises the option to verify it's doing what you intend. 3) Include "closes #173" in the commit message summary.

@ctrochalakis

This comment has been minimized.

Copy link
Contributor Author

ctrochalakis commented Jun 25, 2010

fixed!

@kneath

This comment has been minimized.

Copy link

kneath commented Jul 25, 2010

Awesome, looks like this would fix the SmartyPants issue I was discussing earlier.

Looks like all that's left is the issue closing message.

@kneath

This comment has been minimized.

Copy link

kneath commented Aug 2, 2010

Just confirmed this fixes the issue for me: http://github.com/ctrochalakis/jekyll/compare/mojombo:master...rdiscount_extensions

Please to be merging :)

@mojombo

This comment has been minimized.

Copy link
Contributor

mojombo commented Aug 24, 2010

Merged in 0.7.0.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.