Jekyll crashes when 'time' is not defined in the site configuration. #184

Closed
postmodern opened this Issue Jun 27, 2010 · 4 comments

Projects

None yet

4 participants

@postmodern
Contributor

I noticed that Jekyll crashes when 'time' is not present in the site configuration. When jekyll calls Site#reset, it will attempt to either parse the 'time' setting or use Time.now:

Time.parse(self.config['time'].to_s) || Time.now

If config['time'] is nil, an empty String will be passed to Time.parse. Unfortunately on Ruby 1.9.1 and 1.9.2-preview3, Time.parse does not accept nil or empty Strings:

/home/hal/.rvm/rubies/ruby-1.9.2-preview3/lib/ruby/1.9.1/time.rb:263:in `parse': no time information in "" (ArgumentError)
from /home/hal/.rvm/gems/ruby-1.9.2-preview3/gems/jekyll-0.6.2/lib/jekyll/site.rb:31:in `reset'

This was easily fixed in this commit: http://github.com/postmodern/jekyll/commit/c707102fbfa086cd2e7a182d304f9c61cf520d71

@CameronGilroy

This really needs to be fixed! I am runing Mac OSX 10.6 and "ruby-1.9.2-head"

@postmodern
Contributor

This is still broken, and Ruby 1.9.2 has been released. My patch still resolves the issue on Ruby 1.9.2.

@mojombo
Contributor
mojombo commented Aug 24, 2010

Merged in 0.7.0.

@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.