New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jekyll crashes when 'time' is not defined in the site configuration. #184

Closed
postmodern opened this Issue Jun 27, 2010 · 4 comments

Comments

Projects
None yet
4 participants
@postmodern
Contributor

postmodern commented Jun 27, 2010

I noticed that Jekyll crashes when 'time' is not present in the site configuration. When jekyll calls Site#reset, it will attempt to either parse the 'time' setting or use Time.now:

Time.parse(self.config['time'].to_s) || Time.now

If config['time'] is nil, an empty String will be passed to Time.parse. Unfortunately on Ruby 1.9.1 and 1.9.2-preview3, Time.parse does not accept nil or empty Strings:

/home/hal/.rvm/rubies/ruby-1.9.2-preview3/lib/ruby/1.9.1/time.rb:263:in `parse': no time information in "" (ArgumentError)
from /home/hal/.rvm/gems/ruby-1.9.2-preview3/gems/jekyll-0.6.2/lib/jekyll/site.rb:31:in `reset'

This was easily fixed in this commit: http://github.com/postmodern/jekyll/commit/c707102fbfa086cd2e7a182d304f9c61cf520d71

@postmodern

This comment has been minimized.

@CameronGilroy

This comment has been minimized.

CameronGilroy commented Aug 15, 2010

This really needs to be fixed! I am runing Mac OSX 10.6 and "ruby-1.9.2-head"

@postmodern

This comment has been minimized.

Contributor

postmodern commented Aug 19, 2010

This is still broken, and Ruby 1.9.2 has been released. My patch still resolves the issue on Ruby 1.9.2.

@mojombo

This comment has been minimized.

Contributor

mojombo commented Aug 24, 2010

Merged in 0.7.0.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.